-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update auto component error messages #643
Merged
alanko0511
merged 1 commit into
main
from
alan/rmn-111-better-autocomponent-error-messages
Sep 19, 2024
Merged
Update auto component error messages #643
alanko0511
merged 1 commit into
main
from
alan/rmn-111-better-autocomponent-error-messages
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanko0511
force-pushed
the
alan/rmn-111-better-autocomponent-error-messages
branch
from
September 16, 2024 19:48
0e92c4d
to
0e00432
Compare
danroberts
reviewed
Sep 17, 2024
alanko0511
force-pushed
the
alan/rmn-111-better-autocomponent-error-messages
branch
4 times, most recently
from
September 17, 2024 20:01
7c88703
to
fa6ca4a
Compare
export const TriggerableActionRequiredErrorMessage = `"action" must be a valid Gadget action with an API trigger to be used in AutoForms`; | ||
|
||
export const MissingActionPropErrorMessage = "Specify a valid Gagdet action to use AutoForm"; | ||
export const InvalidActionErrorMessage = `"action" is not a valid Gadget action`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: maybe mention here that the action is used in AutoForm
danroberts
reviewed
Sep 17, 2024
alanko0511
force-pushed
the
alan/rmn-111-better-autocomponent-error-messages
branch
from
September 18, 2024 13:58
fa6ca4a
to
e270c73
Compare
alanko0511
force-pushed
the
alan/rmn-111-better-autocomponent-error-messages
branch
from
September 18, 2024 14:53
e270c73
to
3386194
Compare
MillanWangGadget
approved these changes
Sep 18, 2024
danroberts
approved these changes
Sep 19, 2024
alanko0511
deleted the
alan/rmn-111-better-autocomponent-error-messages
branch
September 19, 2024 18:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the error message when an invalid model or action is passed to AutoForm or AutoTable.
PR Checklist